Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: CI was not building API docs #173

Merged
merged 1 commit into from
Nov 15, 2023
Merged

BugFix: CI was not building API docs #173

merged 1 commit into from
Nov 15, 2023

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Nov 15, 2023

Unclear when this was introduced, I assume the default argument changed from ON to OFF but nothing obvious stands out from git blame.

Closes #172


Build API 3.x action now includes the compilation output [ 1%] Generate API documentation for api_docs_xml and takes much longer with all the writing output... [ 27%] api/define_HostAgentAPI_8cuh_1a64629b6c7aa246731d1657c3ad70996a lines.

API artifacts are now ~40mb compared to 4mb, and downloading one showed the API pages present.

@Robadob Robadob added the bug Something isn't working label Nov 15, 2023
@Robadob Robadob self-assigned this Nov 15, 2023
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI now taking much longer so building again.

Based on CI times, seems to have been ~2 months ago, but the first faster CI job didn't make any related changes so unclear exactly what changed / might be something in the main repo?

@ptheywood ptheywood merged commit 2dcf4f8 into master Nov 15, 2023
5 checks passed
@ptheywood ptheywood deleted the fix_ci_api_docs branch November 15, 2023 10:05
ptheywood added a commit that referenced this pull request Nov 15, 2023
Complements #173 and actually fixes the published cI build
ptheywood added a commit that referenced this pull request Nov 15, 2023
Complements #173 and actually fixes the published cI build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Docs not currently built on docs website
2 participants